Tidy monorepo setup #15128
Merged
Tidy monorepo setup #15128
+200
−645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
adrinr
force-pushed
the
labday/monorepo-setup
branch
from
f628f45 to
38b988b
Compare
adrinr
requested review from
samwho and
mike12345567
and removed request for
a team
samwho
approved these changes
Dec 10, 2024
adrinr
commented
Dec 10, 2024
| @@ -134,10 +134,10 @@ const environment = { | |||
| BUDIBASE_ENVIRONMENT: process.env.BUDIBASE_ENVIRONMENT, | |||
| JS_BCRYPT: process.env.JS_BCRYPT, | |||
| JWT_SECRET: process.env.JWT_SECRET | |||
| ? createSecretKey(Buffer.from(process.env.JWT_SECRET)) | |||
| ? createSecretKey(process.env.JWT_SECRET, "utf8") | |||
There was a problem hiding this comment.
This is a strange case... We are using node 20, and based on their docs, it should accept "buffer" as a parameter. But the types don't allow it. Until now it was working as we were wrongly using node 22 types
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Making a better use of the yarn workspace, cleaning up and removing some unnecessary processes:
Related:
Feature branch env
Feature Branch Link